Update breakage: use organization-wide workflow#110
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s breakage-check automation to use the organization-wide reusable workflows (per JuliaSmoothOptimizers/.github#18), replacing the previously in-repo implementation.
Changes:
- Replace the full local
Breakageworkflow implementation with a call to the org reusable workflow. - Add a
CommentBreakageworkflow that runs onworkflow_runto post results via the org reusable workflow. - Remove the local
.breakageJulia helper script and itsProject.tomlsince that logic is now handled upstream.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/Breakage.yml |
Switched to org reusable workflow for running breakage checks. |
.github/workflows/CommentBreakage.yml |
New workflow to comment breakage results using org reusable workflow on workflow_run. |
.breakage/get_jso_users.jl |
Removed local dependency-discovery script now superseded by org workflow. |
.breakage/Project.toml |
Removed local breakage workflow dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| workflows: ["Breakage"] | ||
| types: | ||
| - completed | ||
|
|
There was a problem hiding this comment.
CommentBreakage triggers a workflow that (presumably) writes a PR comment, but this workflow doesn’t declare any explicit permissions. If the repo’s default GITHUB_TOKEN permission is set to read-only, the reusable workflow won’t be able to create/update PR comments. Add an explicit permissions: block (e.g., issues: write and/or pull-requests: write, plus contents: read if needed) at the workflow level so the called workflow can function reliably while staying least-privilege.
| permissions: | |
| contents: read | |
| issues: write | |
| pull-requests: write |
There was a problem hiding this comment.
This is fine because we run on workflow_run I think.
Following JuliaSmoothOptimizers/.github#18.